New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bughorizon #76

Merged

seabbs merged 3 commits into epiforecasts:master from tuxette:bughorizon

Jun 22, 2020

tuxette commented Jun 10, 2020

fixed a bug on 'horizon' not handled properly in predict_cases() (due to non standard evaluation by tidyverse and confusion in argument/column names)
added unit tests to assess this issue for predict_cases() and forecast_cases()

Nathalie Vialaneix added 3 commits

June 10, 2020 12:51


          fixed issue #42

f1e7eaf


          added new tests for forecast_cases()

55b96f7


          added tests for 'horizon' in predict_cases()

915a454

seabbs approved these changes

View reviewed changes

Contributor

seabbs left a comment

Nice catch and good work on the additional tests - sorry for the delay review. This very helpful stuff.

seabbs merged commit 704cb51 into epiforecasts:master

sbfnk mentioned this pull request

'horizon' in forecast_cases() #42

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet