-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VaToast #4373): add bottom-center, top-center position options #4377
Merged
m0ksem
merged 6 commits into
epicmaxco:develop
from
tom00502:feat/va-toast-add-position-options
Sep 23, 2024
Merged
feat(VaToast #4373): add bottom-center, top-center position options #4377
m0ksem
merged 6 commits into
epicmaxco:develop
from
tom00502:feat/va-toast-add-position-options
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuestic-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vuestic-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m0ksem
approved these changes
Sep 13, 2024
m0ksem
added a commit
that referenced
this pull request
Oct 17, 2024
…4377) * feat(VaToast #4373): add bottom-center, top-center position options * fix: correctly handle multiple toasts offset * chore(toast): fix paddings * chore: remove redundant * fix(toast): improve appear and close animations --------- Co-authored-by: Parsons <[email protected]> Co-authored-by: Maksim Nedoshev <[email protected]>
raichev-dima
pushed a commit
to raichev-dima/vuestic-ui
that referenced
this pull request
Dec 12, 2024
…options (epicmaxco#4377) * feat(VaToast epicmaxco#4373): add bottom-center, top-center position options * fix: correctly handle multiple toasts offset * chore(toast): fix paddings * chore: remove redundant * fix(toast): improve appear and close animations --------- Co-authored-by: Parsons <[email protected]> Co-authored-by: Maksim Nedoshev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bottom-center, top-center position options to VaToast
Description
Two new position options have been added to Vatoast: 'top-center' and 'bottom-center'.
closes #4373
'top-center': Displays the toast at the top center of the screen.
'bottom-center': Displays the toast at the bottom center of the screen.
The Y-axis shift overlay and fade-out animation when the toast appears have been taken into account.
In order to handle the relationship of the animation starting point, it was necessary to add the 'center' class to the toast for these two options.
Types of changes