Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a :success-test to shell to test the return code #114

Closed
retrogradeorbit opened this issue Jul 9, 2020 · 1 comment
Closed

add a :success-test to shell to test the return code #114

retrogradeorbit opened this issue Jul 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@retrogradeorbit
Copy link
Member

tomc 4:05 AM
I've run into a situation a few times now where I want to run a shell command not have non-zero exit codes crash the script. Would it make sense for spire to allow something like that? perhaps (shell {:cmd "whatever" :accept-codes #{0 254}})?
Crispin 10:41 AM
yeah that makes total sense. the module curl has something like that :success-test. Would make it take a function, so you could put a predicate there, or a set.
@retrogradeorbit retrogradeorbit added the enhancement New feature or request label Jul 9, 2020
retrogradeorbit added a commit that referenced this issue Jul 27, 2020
@retrogradeorbit
add :ok-exit and :changed-exit arguments to shell module - #114
512a2ac
@retrogradeorbit
Copy link
Member Author

released in v0.1.0-alpha.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@retrogradeorbit