Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4 script templates fix #93

Open
wants to merge 2 commits into
base: godot4
Choose a base branch
from

Conversation

daneehAI
Copy link

@daneehAI daneehAI commented Feb 7, 2025

RESOLVES ISSUE #82

Update script templates with Godot 4 syntax and folder hierarchy:

  • Place script templates in a Node subfolder, which is required for Godot 4 to detect the script templates
  • Replace % with _ (example: %BASE% becomes BASE, %TS% becomes TS), according to new Godot 4 syntax for script templates

Place script templates in a Node subfolder, which is required for Godot 4 to detect the script templates
Replace % with _ (example: %BASE% becomes _BASE_, %TS% becomes _TS_), according to new Godot 4 syntax for script templates
…e inkgd script templates

Godot 4 reads the names of subfolders within the script_templates folder. The script templates within those folders become available to the node type that is that subfolder name. With subfolder name Control, Godot 4 only allows Control node scripts to use the inkgd script templates. With subfolder name Node, any node script can use the inkgd script templates.
@manuq
Copy link

manuq commented Feb 26, 2025

@daneehAI oh I didn't notice your PR so I the same thing in parallel #97

However, note that this is not enough. In my PR I have also changed the plugin to install the script templates correctly: https://github.com/ephread/inkgd/pull/97/files#diff-e377186e5b5fa5981f46565ec79c2653e506b4de56e478273341c81f207f3d96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants