Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Theme via Session #105

Closed
2 tasks done
ephes opened this issue Aug 30, 2023 · 1 comment
Closed
2 tasks done

Set Theme via Session #105

ephes opened this issue Aug 30, 2023 · 1 comment
Assignees
@ephes
Labels
enhancement New feature or request

Comments

@ephes
Copy link
Owner

ephes commented Aug 30, 2023 •
edited
Loading

It should be possible to have a dropdown etc. to let the website user select the theme.

  • Use theme provided by session if there's one
  • Be able to select the theme and store the result in the requests session
@ephes ephes added the enhancement New feature or request label Aug 30, 2023
@ephes ephes self-assigned this Aug 30, 2023
ephes added a commit that referenced this issue Aug 30, 2023
@ephes
#105 if there's a template base dir setting in the session use this i…
c17ef18 
…nstead of the default template base dir of blog or site
@ephes
Copy link
Owner Author

ephes commented Aug 31, 2023

Has select_theme.html to be implemented for a minimal theme?

ephes added a commit that referenced this issue Aug 31, 2023
@ephes
#105 fix grammar
0b72a7c
ephes added a commit that referenced this issue Sep 1, 2023
@ephes
#105 select theme view + tests and some refactoring
40920b0
ephes added a commit that referenced this issue Sep 2, 2023
@ephes
#105 log that htmx target was None instead of raising a ValueError be…
a74e039 
…cause on theme change it is and that's ok + test modification
ephes added a commit that referenced this issue Sep 2, 2023
@ephes
#105 added select_theme template for bootstrap4
b464678
ephes added a commit that referenced this issue Sep 2, 2023
@ephes
#105 added a theme list endpoint to cast api
1f32884
ephes added a commit that referenced this issue Sep 2, 2023
@ephes
#105 ignore some mypy errors I don't know how to fix :/
31b8f48
ephes added a commit that referenced this issue Sep 3, 2023
@ephes
#105 added an api view to be able to update the selected theme
126aaf3
ephes added a commit that referenced this issue Sep 3, 2023
@ephes
#105 update release logs
5ac3bef
ephes added a commit that referenced this issue Sep 3, 2023
@ephes
#105 add an api endpoint to be able to update the selected theme + tests
41abb4c
ephes added a commit that referenced this issue Sep 3, 2023
@ephes
#105 just use forms with post for theme selection -> much better and …
d890d8f 
…less code as well
ephes added a commit that referenced this issue Sep 6, 2023
@ephes
#105 get the right theme from the session in the api views by passing…
628dc28 
… the api request to the page via ProxyRequest
ephes added a commit that referenced this issue Sep 7, 2023
@ephes
#105 removed obsolete debug
8c4aabc
ephes added a commit that referenced this issue Sep 7, 2023
@ephes
#105 add proper context manager for passing request to wagtail pages …
e067354 
…+ test
ephes added a commit that referenced this issue Sep 8, 2023
@ephes
#105 improved documentation for themes
9fc980a
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 remove ProxyRequest since we get the request now via HtmlField w…
e4d1d4f 
…hich is much simpler, yay!
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 update release notes
eb15c51
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 only show theme selector on pages where the theme can be changed
5cc7632
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 make sure blog pages have has_selectable_themes in context
d4e8a0c
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 updated release notes for theme selector flag
1d997c4
ephes added a commit that referenced this issue Sep 9, 2023
@ephes
#105 removed debug output
c794873
@ephes ephes closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ephes ephes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ephes