Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6383 dna antisense chains #6571

Merged
merged 10 commits into from
Feb 28, 2025
Merged

6383 dna antisense chains #6571

merged 10 commits into from
Feb 28, 2025

Conversation

ALexanderSPB
Copy link
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess right screenshot is incorrect because tooltip cover all RNA Builder

@svvald
Copy link
Collaborator

svvald commented Feb 26, 2025

It works good and the option to create a DNA antisense strand is present in context menu in sequence mode
image
However, this option is missing in flex/snake mode, there is only one option to create an antisense strand (RNA):
image

According to the feature requirements,

DNA antisense chain creation should be supported in all three macromolecules modes and can be executed either by choosing "Create DNA Antisense Strand" from the right-click drop-down menu after appropriate monomers are selected

@ALexanderSPB Could you please adjust it as well?

@NataliaLoginova NataliaLoginova merged commit 36d3df1 into master Feb 28, 2025
20 of 26 checks passed
@NataliaLoginova NataliaLoginova deleted the 6383-dna-antisense-chains branch February 28, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce the creation of DNA antisense chains
5 participants