#4853-Search monomer in library by IDT #5373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrodionov91
approved these changes
Sep 2, 2024
| const modifications = item.idtAliases?.modifications; | ||
| let transformedIdtText = idtName; | ||
|
|
||
| if (item.name?.includes('MOE') && idtName) { |
There was a problem hiding this comment.
We should not rely on monomer name because we will have other monomers with idt aliases in future
Comment on lines
+432
to
+446
| switch (position) { | ||
| case PresetPosition.Library: | ||
| transformedIdtText = `${endpoint5}, ${internal}`; | ||
| break; | ||
| case PresetPosition.ChainStart: | ||
| transformedIdtText = endpoint5; | ||
| break; | ||
| case PresetPosition.ChainMiddle: | ||
| transformedIdtText = internal; | ||
| break; | ||
| case PresetPosition.ChainEnd: | ||
| transformedIdtText = endpoint3; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Position does not play any role in library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue => #4853
Updates:
User be able to search by IDT aliases in a library using search bar.
Single symbol / in a query result in displaying all the monomers that have IDT alias.
The symbol after / is the first symbol of the IDT alias.
The symbol before the second / is the last symbol of the IDT alias.
Searching diPr/ should return a monomer with alias i6diPr, but searching diP/` should not.
If there is any symbol after the second slash, there shouldn't be any results.
The search is not case sensitive.
Check list
#1234 – issue name