Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4884 – Implement basic preview display for monomer bonds #5293

Merged
merged 12 commits into from
Aug 23, 2024
Merged

#4884 – Implement basic preview display for monomer bonds #5293

merged 12 commits into from
Aug 23, 2024

Conversation

svvald
Copy link
Collaborator

@svvald svvald commented Aug 14, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@svvald svvald linked an issue Aug 14, 2024 that may be closed by this pull request
Add preview for hovering over a bond #4884
Closed
@svvald svvald force-pushed the 4884-add-preview-for-hovering-over-a-bond branch from 7b5157c to fa2051f Compare August 20, 2024 13:52
@svvald svvald force-pushed the 4884-add-preview-for-hovering-over-a-bond branch from fa2051f to a3b8e9e Compare August 21, 2024 15:54
@rrodionov91 rrodionov91 merged commit a3ba06e into master Aug 23, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4884-add-preview-for-hovering-over-a-bond branch August 23, 2024 09:43
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@svvald @Guch1g0v
#4884 – Implement basic preview display for monomer bonds (#5293)
d3ac91a 
* #4884 – Add on mouse move handlers to bonds to hide preview
* #4884 – Refactor labels styling in previews, add correct color for bond previews
* #4884 – Update screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

Assignees

@svvald svvald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add preview for hovering over a bond
2 participants
@svvald @rrodionov91