Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #5242 - Replace phosphate at the end with petide causes cycled polymer #5259

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Backmerge: #5242 - Replace phosphate at the end with petide causes cycled polymer #5259

merged 2 commits into from
Aug 9, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Aug 8, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91
#5242 - Replace phosphate at the end with petide causes cycled polymer
997ff4d 
- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
This was linked to issues Aug 8, 2024
Replace phosphate at the end with petide causes cycled polymer #5242
Closed
System merge sequences while replacing selected monomers from the library in view mode #5241
Closed
System merge sequences while replacing selected monomers from the library in edit mode #5234
Closed
This was linked to issues Aug 8, 2024
Replacement of preset at the begining of sequence on another preset (C) wipes out entire sequence #5247
Closed
Undo of replacing all DNAs in sequence in view mode on preser (C) from the library causes undeletable monomer on the canvas (all of them) #5250
Closed
Replacing all DNAs in sequence in view mode on CHEM (A6OH) from the library causes invalid flex canvas #5253
Closed
Replacing all nucleosides (i.e. w/o base) with peptides from the library in view mode causes invalid canvas - hanging bond and undeletable @ symbol #5254
Closed
@rrodionov91 rrodionov91 changed the title #5242 - Replace phosphate at the end with petide causes cycled polymer Backmerge: #5242 - Replace phosphate at the end with petide causes cycled polymer Aug 9, 2024
@rrodionov91 rrodionov91 merged commit 5506be9 into master Aug 9, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 5242-replace-phosphate-issue branch August 9, 2024 12:29
@rrodionov91 rrodionov91 linked an issue Aug 9, 2024 that may be closed by this pull request
Replacing multiple monomers wrapped into @ symbol inserts only one monomer instead of multiple ones #5268
Open
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5242 - Replace phosphate at the end with petide causes cy…
ffffb5d 
…cled polymer (#5259)

- changed usage of previous/next node to previous/next node in same chain for replacing sequence items through the library
- fixed replacement of single selection of two chains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undo of replacing all DNAs in sequence in view mode on preser (C) from the library causes undeletable monomer on the canvas (all of them) Replacement of preset at the begining of sequence on another preset (C) wipes out entire sequence Replace phosphate at the end with petide causes cycled polymer System merge sequences while replacing selected monomers from the library in view mode System merge sequences while replacing selected monomers from the library in edit mode
Replacing all DNAs in sequence in view mode on CHEM (A6OH) from the library causes invalid flex canvas Replacing all nucleosides (i.e. w/o base) with peptides from the library in view mode causes invalid canvas - hanging bond and undeletable @ symbol Replacing multiple monomers wrapped into @ symbol inserts only one monomer instead of multiple ones
2 participants
@rrodionov91 @svvald