Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5005 - Use ketcher-standalone with separate indigo wasm file by default in ketcher example #5012

Merged
merged 2 commits into from
Jul 5, 2024
Merged

#5005 - Use ketcher-standalone with separate indigo wasm file by default in ketcher example #5012

merged 2 commits into from
Jul 5, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jul 5, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • reverted usage of base64 indigo wasm for dev mode

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91
#5005 - Use ketcher-standalone with separate indigo wasm file by defa…
b2f73b0 
…ult in ketcher example

- reverted usage of base64 indigo wasm for dev mode
@rrodionov91 rrodionov91 linked an issue Jul 5, 2024 that may be closed by this pull request
Use ketcher-standalone with separate indigo wasm file by default in ketcher example #5005
Closed
@rrodionov91 rrodionov91 merged commit 43aec07 into master Jul 5, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 5005-separate-wasm-by-default-2 branch July 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-asiyuk-epam ilya-asiyuk-epam Awaiting requested review from ilya-asiyuk-epam

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ketcher-standalone with separate indigo wasm file by default in ketcher example
1 participant
@rrodionov91