#4837 - Library filter does not reset when switching between Micro and Macro mode #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svvald
reviewed
Jun 18, 2024
| setFirstRender(false); | ||
| dispatch(setSearchFilter('')); | ||
| } | ||
| }, [dispatch, firstRender]); |
There was a problem hiding this comment.
I think you don't need firstRender flag, if you just leave useEffect dependencies array empty, it will fire only once on mount, can you check will it work?
svvald
approved these changes
Jun 18, 2024
NataliaLoginova
approved these changes
Jun 19, 2024
NataliaLoginova
deleted the
4837-library-filter-does-not-reset-when-switching-between-micro-and-macro-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Adding logic to track the first rendering of a component
Check list
#1234 – issue name