Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #4740 - Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4762

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Backmerge: #4740 - Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4762

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cea293
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
rrodionov91 Jun 5, 2024
873c2ef
- skip handling of adding/deleteing phosphates and establishing bonds…
rrodionov91 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ketcher-core/src/application/editor/modes/SequenceMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ export class SequenceMode extends BaseMode {
const nodeAfterSelection = SequenceRenderer.getNextNode(selectionEndNode);
const nodeInSameChainBeforeSelection =
SequenceRenderer.getPreviousNodeInSameChain(selectionStartNode);
const nodeInSameChainAfterSelection =
SequenceRenderer.getNextNodeInSameChain(selectionEndNode);

if (
!nodeInSameChainBeforeSelection &&
Expand All @@ -547,7 +549,9 @@ export class SequenceMode extends BaseMode {

if (
!nodeBeforeSelection ||
nodeBeforeSelection instanceof EmptySequenceNode
nodeBeforeSelection instanceof EmptySequenceNode ||
nodeBeforeSelection !== nodeInSameChainBeforeSelection ||
nodeAfterSelection !== nodeInSameChainAfterSelection
) {
return;
}
Expand Down
Loading