Autotests: #4712 - Set longer timeouts for wait control operations for heavy tests, set propper tags #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, set propper tags
auto-assign
bot
requested review from
ilya-asiyuk-epam,
StarlaStarla and
Zhirnoff
…totests-set-longer-timeouts-for-wait-control-operations-for-heavy-tests-set-propper-tags
…totests-set-longer-timeouts-for-wait-control-operations-for-heavy-tests-set-propper-tags
AlexeyGirin
requested review from
rrodionov91
and removed request for
StarlaStarla and
ilya-asiyuk-epam
rrodionov91
approved these changes
Jun 17, 2024
Comment on lines
308
to
315
| await waitForSpinnerFinishedWork( | ||
| page, | ||
| async () => await page.keyboard.press('Control+c'), | ||
| ); | ||
|
|
||
| await waitForSpinnerFinishedWork(page, async () => | ||
| page.keyboard.press('Control+v'), | ||
| ); |
There was a problem hiding this comment.
I would propose to wrap copy/cut/paste into helpers. to not write everytime
await waitForSpinnerFinishedWork(page, async () =>
page.keyboard.press('Control+v'),
);
But write just
await copy(page)
await paste(page)
rrodionov91
approved these changes
Jun 20, 2024
rrodionov91
changed the title
rrodionov91
deleted the
4712-autotests-set-longer-timeouts-for-wait-control-operations-for-heavy-tests-set-propper-tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name