#3824 - Macro: Modify nucleotides from sequence in RNA builder #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-asiyuk-epam
changed the title
ilya-asiyuk-epam
force-pushed
the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
2 times, most recently
from
1812d78 to
a73439f
Compare
ilya-asiyuk-epam
force-pushed
the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
10 times, most recently
from
80cd987 to
1e622ba
Compare
ilya-asiyuk-epam
changed the title
ilya-asiyuk-epam
force-pushed
the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
5 times, most recently
from
3b963d7 to
d6d5a45
Compare
rrodionov91
requested changes
Apr 8, 2024
...src/components/monomerLibrary/RnaBuilder/RnaEditor/RnaEditorExpanded/helpers/sequenceEdit.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+41
| if (groupName === MonomerGroups.BASES) { | ||
| setIsDisabled(!item?.props?.MonomerCaps?.R1); | ||
| } else if (groupName === MonomerGroups.PHOSPHATES) { | ||
| setIsDisabled( | ||
| !(item?.props?.MonomerCaps?.R1 && item?.props?.MonomerCaps?.R2), | ||
| ); | ||
| } else if (groupName === MonomerGroups.SUGARS) { | ||
| if (isSequenceFirstsOnlyNucleotidesSelected) { | ||
| setIsDisabled( | ||
| !(item?.props?.MonomerCaps?.R3 && item?.props?.MonomerCaps?.R2), | ||
| ); | ||
| } else { | ||
| setIsDisabled( | ||
| !( | ||
| item?.props?.MonomerCaps?.R3 && | ||
| item?.props?.MonomerCaps?.R2 && | ||
| item?.props?.MonomerCaps?.R1 | ||
| ), | ||
| ); | ||
| } | ||
| } | ||
| }, [ |
There was a problem hiding this comment.
I believe we need to move the logic about which monomer item is valid for rna connection to ketcher-core package because probably we can use it in future for different purposes and places. I would propose to create a static method in Phosphate, RnaBase and Sugar classes which receives monomerItem and returns boolean.
packages/ketcher-macromolecules/src/components/contextMenu/SequenceItemContextMenu/helpers.ts
Outdated
Show resolved
Hide resolved
ilya-asiyuk-epam
force-pushed
the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
2 times, most recently
from
66319d6 to
3c29f3c
Compare
ilya-asiyuk-epam
force-pushed
the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
from
3c29f3c to
edf94e6
Compare
rrodionov91
approved these changes
Apr 9, 2024
rrodionov91
deleted the
3824-macro-modify-nucleotides-from-sequence-in-rna-builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name