Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solvents) on the canvas causes spontaneous random de-abbreviation #4123

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Feb 21, 2024

  • fixed functional group id setting

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…nts) on the canvas causes spontaneous random de-abbreviation

- fixed functional group id setting
- added setting sgroup id on deserialisation step
- added functional groups id mapping to link functional groups properly during struct merge
@rrodionov91 rrodionov91 merged commit 5395b1d into release/2.19 Feb 23, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 3891-salts-dearomatize-autoexpanding branch February 23, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants