Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3943 - System allow to create atoms with Charge value out or range #4079

Conversation

DzhafarOFF
Copy link
Collaborator

@DzhafarOFF DzhafarOFF commented Feb 13, 2024

How did you fix the issue?

Screenshots

Atom's charge out of allowed range Screenshot 2024-02-13 at 16 12 42
Atom's charge in allowed range Screenshot 2024-02-13 at 16 12 53

Please also review fix for corner case with zero charge defined explicitly:

Current behaviour All zero charge values get displayed on canvas and explicitly shown in atom's property field but get removed after export anyway
Current.mov
Proposed behavaiour All zero values don't get displayed on canvas and don't get shown in atom's property field. So there is no difference with default atom after explicitly setting zero as charge value.
Fixed.mov

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 merged commit c6e7c7c into master Apr 17, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 3943-system-allow-to-create-atoms-with-charge-value-out-or-range branch April 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System allow to create atoms with Charge value out or range
3 participants