Macro: #3756 - Loading from file and than - Undo changes causes exceptions and breakes selection/moving fuctionality #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions and breakes selection/moving fuctionality - fixed DrawingEntitiesManager merge method to collect return command - fixed history setting after opening file to store command for the main DrawingEntitiesManager
9 tasks
Nitvex
approved these changes
Dec 29, 2023
| @@ -297,6 +297,7 @@ export class DrawingEntitiesManager { | |||
| rectangleBottomRightPoint: Vec2, | |||
| ) { | |||
| const command = new Command(); | |||
| console.log(this.polymerBonds); | |||
There was a problem hiding this comment.
I propose to remove this one :)
rrodionov91
deleted the
3756-macro-loading-from-file-and-than-undo-changes-causes-exceptions-and-breakes-selection-moving
branch
rrodionov91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name