Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: #3385 - Overlapping of bonds between 2 monomers #3453

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Macro: #3385 - Overlapping of bonds between 2 monomers #3453

merged 7 commits into from
Oct 18, 2023

Conversation

chgayane
Copy link
Collaborator

@chgayane chgayane commented Oct 17, 2023 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@chgayane chgayane linked an issue Oct 17, 2023 that may be closed by this pull request
Macro: Overlapping of bonds between 2 monomers #3385
Closed
@chgayane chgayane marked this pull request as ready for review October 17, 2023 09:40
@Nitvex Nitvex changed the title #3385 - Macro: Overlapping of bonds between 2 monomers Macro: #3385 - Overlapping of bonds between 2 monomers Oct 17, 2023
@MartaWilliams
Copy link
Collaborator

Tested
2023-10-18_13h08_25

@Nitvex Nitvex merged commit b8865be into master Oct 18, 2023
@Nitvex Nitvex deleted the 3385-overlapping-of-bonds-between-2-monomers branch October 18, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlaStarla StarlaStarla StarlaStarla approved these changes

@Nitvex Nitvex Nitvex approved these changes

@MartaWilliams MartaWilliams MartaWilliams approved these changes

Assignees

@chgayane chgayane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro: Overlapping of bonds between 2 monomers
4 participants
@chgayane @MartaWilliams @StarlaStarla @Nitvex