Autotests: #2885 - Create autotests for atom tools #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added expected snapshots; - added function 'takeRightToolbarScreenshot'
- added expected snapshots; - added 12 test files
…totests-create-autotests-for-atom-tools
Nitvex
reviewed
Sep 27, 2023
| 'Molfiles-V2000/structure-list-notlist.mol', | ||
| page, | ||
| ); | ||
| // eslint-disable-next-line no-magic-numbers |
There was a problem hiding this comment.
can we use a constant here?
- added expected snapshots; - added 1 test file;
…totests-create-autotests-for-atom-tools
- added expected snapshots; - added 'type Atoms = Exclude' to 'buttons.ts'
…totests-create-autotests-for-atom-tools
auto-assign
bot
requested review from
OlgaMazurina,
SashaGraves and
ViktoriaTkacheva
SashaGraves
approved these changes
Sep 29, 2023
OlgaMazurina
approved these changes
Sep 29, 2023
- refactoring function selectAtomsFromPeriodicTable; - added data-testid to 'Atom.jsx'
- added 'excludeAtoms.ts'
…totests-create-autotests-for-atom-tools
AnastasiyaPiatrovaKlu
pushed a commit
that referenced
this pull request
Oct 2, 2023
* - added 6 tests to 'atom-tool'; - added expected snapshots; - added function 'takeRightToolbarScreenshot' * - added tests to 'atom-tools'; - added expected snapshots; - added 12 test files * - added tests to 'atom-tool' - added expected snapshots; - added 1 test file; * - added tests to 'atom-tools'; - added expected snapshots; - added 'type Atoms = Exclude' to 'buttons.ts' * - code refactoring; - refactoring function selectAtomsFromPeriodicTable; - added data-testid to 'Atom.jsx' * - code refactoring; - added 'excludeAtoms.ts'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name