Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2584 #2750 - Selection tool: add flip and delete buttons & Rotation Tool: non-selected end of the selected bond should be the rotation center #2666

Merged
merged 26 commits into from
Jun 9, 2023
Merged

#2584 #2750 - Selection tool: add flip and delete buttons & Rotation Tool: non-selected end of the selected bond should be the rotation center #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
14e68c8
#2584 - Refactor: add type declarations to external module 'subscript…
yuleicul May 25, 2023
1481bed
#2584 - Add new reducer for floating tools
yuleicul May 25, 2023
278cc9d
#2584 - Add new component FloatingTools
yuleicul May 25, 2023
b5be355
#2584 - Update position of floating tools
yuleicul May 26, 2023
1a72a8d
#2584 - Fix position to be correct after scrolling and zooming
yuleicul May 26, 2023
7f43f45
#2584 - Fix rotation box to be rerendered after flipping
yuleicul May 26, 2023
c84916e
#2584 - Fix floating tools to update position when scrolling
yuleicul May 26, 2023
696e811
#2584 - Update erase button's icon to delete
yuleicul May 28, 2023
cc623f6
#2584 - Remove transform tool group from left toolbar
yuleicul May 28, 2023
80e1b7e
#2584 - Rename handlePos to rotateHandlePosition
yuleicul May 31, 2023
1a96c3a
#2584 - Expose a public method to handle scrolling
yuleicul May 31, 2023
26035aa
#2584 - Make handleCenter private
yuleicul May 31, 2023
884de7e
#2584 - Change Vec2 to {x, y}
yuleicul May 31, 2023
08d8d4d
#2584 - Remove raphael2view
yuleicul May 31, 2023
9c5b2d7
#2584 - Fix ci
yuleicul May 31, 2023
7397179
Merge branch 'master' into 2584-selection-tool-add-flip-and-delete-bu…
yuleicul May 31, 2023
f5ebe2e
#2584 - Fix ci after merging
yuleicul May 31, 2023
1be5a81
#2584 - Support to flip multi structures as a whole
yuleicul Jun 5, 2023
c4c468a
#2584 - Support to flip rxnArrow
yuleicul Jun 5, 2023
b5bd73b
#2584 - Support to flip texts and rxnPluses
yuleicul Jun 5, 2023
2162da6
#2584 - Remove functionality of flipping one single bond
yuleicul Jun 5, 2023
c01f461
#2584 - Remove unused code
yuleicul Jun 5, 2023
8e202b4
#2584 - Fix flip positions of texts
yuleicul Jun 6, 2023
eb2fd76
#2584 - Decouple action generators and UI
yuleicul Jun 6, 2023
0a0a034
#2750 - Fix unselected end of the selected bond to be the center
yuleicul Jun 8, 2023
c74f590
#2584 - Avoid importing type from ui to editor (code review)
yuleicul Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ketcher-core/src/application/editor/actions/fragment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { fromRGroupFragment, fromUpdateIfThen } from './rgroup'

import { Action } from './action'
import { fromAtomsFragmentAttr } from './atom'
import { getRelSgroupsBySelection } from './utils'
import { getRelSGroupsBySelection } from './utils'

export function fromMultipleMove(restruct, lists, d) {
d = new Vec2(d)
Expand Down Expand Up @@ -84,7 +84,7 @@ export function fromMultipleMove(restruct, lists, d) {
})

if (lists.sgroupData && lists.sgroupData.length === 0) {
const sgroups = getRelSgroupsBySelection(restruct, lists.atoms)
const sgroups = getRelSGroupsBySelection(struct, lists.atoms)
sgroups.forEach((sg) => {
action.addOp(new SGroupDataMove(sg.id, d))
})
Expand Down
Loading