#2517 Incorrect rendering of superatom with multiple connection points #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleicul
reviewed
May 12, 2023
| @@ -91,6 +91,29 @@ export function setExpandSGroup(restruct, sgid, attrs) { | |||
| return action.perform(restruct) | |||
| } | |||
|
|
|||
| // todo delete after supporting expand - collapse for 2 attachment points | |||
There was a problem hiding this comment.
Please check if this comment should be removed. If not, my personal opinion is to create a new issue for that, because most todos in the comments are seldom done (if you search 'todo' in our codebase, you'll see more than 200 items😔).
There was a problem hiding this comment.
Added a task for this: #2603
|
Tested, the superatom is fine after a rename |
VasilevDO
approved these changes
May 15, 2023
KonstantinEpam23
approved these changes
May 17, 2023
KonstantinEpam23
deleted the
#2517-incorrect-rendering-of-superatom-with-multiple-connection-points
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.