Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #2517 File with Superatom opens without part of structure #2567

Conversation

AnastasiiaPlyako
Copy link
Collaborator

if sgroup has more than 1 attachment point, we should expand sgroup. I made this logic for paste tool. "Expanded" function invokes in 2 places:

  1. constructor - in that case we firstly render struct from paste and after what we make expand sgroup
  2. mouse move - I can't invoke function "setExpandSGroup" because struct and editor have absolutely different id for atoms and sgroups. I create array sGroupsIdExpanded with id "s groups" which need to be expanded and put this array in "fromPaste" function. if id sgroup is exist in "sGroupsIdExpanded" than field expanded = true
2023-05-02.19.21.11.mov

@AnastasiiaPlyako AnastasiiaPlyako requested review from Nitvex, KonstantinEpam23 and a user May 2, 2023 15:44
@Nitvex Nitvex requested a review from VasilevDO May 2, 2023 15:44
@Nitvex Nitvex linked an issue May 2, 2023 that may be closed by this pull request
@Nitvex Nitvex changed the title #2517 fix bug with disappearing part of structure #2517 File with Superatom opens without part of structure May 2, 2023
@AnastasiiaPlyako AnastasiiaPlyako changed the title #2517 File with Superatom opens without part of structure Backmerge: #2517 File with Superatom opens without part of structure May 3, 2023
@KonstantinEpam23 KonstantinEpam23 merged commit 1a90da3 into master May 3, 2023
@KonstantinEpam23 KonstantinEpam23 deleted the #2517-file-with-superatom-opens-without-part-of-structure branch May 3, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect rendering of superatom with multiple connection points
2 participants