Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2045: Functional Groups: The functional group is not added to one of the H3C #2095

Conversation

St-Permiakov
Copy link
Collaborator

@St-Permiakov St-Permiakov marked this pull request as ready for review January 16, 2023 12:10
Copy link
Collaborator

@Nitvex Nitvex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can be something like

typeof neiId === 'number'

@St-Permiakov
Copy link
Collaborator Author

typeof neiId === 'number won't protect from NaN.
I know that in this particular case it's highly unlikely, but I'd better stick to more stable solution.

@Nitvex
Copy link
Collaborator

Nitvex commented Jan 16, 2023

typeof neiId === 'number won't protect from NaN. I know that in this particular case it's highly unlikely, but I'd better stick to more stable solution.

good point :)

@Nitvex Nitvex merged commit 05a8905 into master Jan 17, 2023
@Nitvex Nitvex deleted the #2045-functional-groups-the-functional-group-is-not-added-to-one-of-the-h3c branch January 17, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional Groups: The functional group is not added to one of the H3C
2 participants