#1852 Implements automatic selection of mol encoding #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitvex
reviewed
Nov 28, 2022
| @@ -29,6 +29,22 @@ import assert from 'assert' | |||
| import { EventEmitter } from 'events' | |||
| import { runAsyncAction } from 'utilities' | |||
|
|
|||
| const Format = { | |||
There was a problem hiding this comment.
I propose to add type for this object. It can be something like:
const Format: {
[key in SupportedFormat]: SupportedFormat
}
This way you don't need to write
Format.SomeFormat as SupportedFormat
There was a problem hiding this comment.
Updated, pls check if it is a good solution
Nitvex
reviewed
Nov 29, 2022
| @@ -117,7 +122,7 @@ const MiewDialog = ({ | |||
| (miew: MiewAsType) => { | |||
| miewRef.current = miew | |||
| const factory = new FormatterFactory(server) | |||
| const service = factory.create('cml') | |||
| const service = factory.create('cml' as SupportedFormat) | |||
There was a problem hiding this comment.
Could you please also change to SupportedFormat.cml?
porcelain11
force-pushed
the
#1852-automatic-selection-of-mol-encoding
branch
from
5dc82ec to
612fff2
Compare
Nitvex
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements automatic selection of mol encoding: add "molAuto" to SupportedFormat type and to formatProperties - with { 'molfile-saving-mode': 'auto' } option.