Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ketcher creates invalid molfiles with "NaN" #1779

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Ketcher creates invalid molfiles with "NaN" #1779

merged 1 commit into from
Oct 20, 2022

Conversation

evgeniiFrolov1
Copy link
Collaborator

  • fixed nan bug. flags convert was fixed in structconv
  • fixed ctabv2000 header. replaced spaces with 0

@evgeniiFrolov1
Ketcher creates invalid molfiles with "NaN"
3c5c457 
  - fixed nan bug. flags convert was fixed in structconv
  - fixed ctabv2000 header. replaced spaces with `0`
porcelain11
porcelain11 reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@porcelain11 porcelain11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough

@evgeniiFrolov1 evgeniiFrolov1 merged commit 7526c0c into release/2.6 Oct 20, 2022
@evgeniiFrolov1 evgeniiFrolov1 deleted the 1778-fix-nan-in-mol-files branch October 20, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcelain11 porcelain11 porcelain11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniiFrolov1 @porcelain11