Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI bloking #1765

Merged
merged 1 commit into from
Oct 13, 2022
Merged

UI bloking #1765

merged 1 commit into from
Oct 13, 2022

Conversation

evgeniiFrolov1
Copy link
Collaborator

@evgeniiFrolov1 evgeniiFrolov1 commented Oct 13, 2022 •
edited
Loading

Loading spinner shows in Ketcher if a user calls setMolecule or addFragment methods via API

porcelain11
porcelain11 reviewed Oct 13, 2022
View reviewed changes
packages/ketcher-react/src/hooks/useSubscribtionOnEvents.ts
const loadingHandler = () => {
dispatch(indigoVerification(true))
}
const actionResultHandler = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good naming

@evgeniiFrolov1
Block UI when setMolecule is called
03bbab1 
    UI is blocked when Ketcher API method is called.
@evgeniiFrolov1 evgeniiFrolov1 changed the title UI bloking Draft UI bloking Oct 13, 2022
@evgeniiFrolov1 evgeniiFrolov1 merged commit 0a7c2a4 into master Oct 13, 2022
@evgeniiFrolov1 evgeniiFrolov1 deleted the 1755-ui-blocking branch October 13, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcelain11 porcelain11 porcelain11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniiFrolov1 @porcelain11