Add line simple object and selection for all #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JerdoAve
commented
Dec 3, 2020
JerdoAve
commented
- change approach for saving of simple objects
- implement highlighting hover and selection behaviour
- add new simple object (line)
# Conflicts: # example/config/webpack.config.js # example/public/index.html
- enhance managing coordinates for simple objects - add line - add polyline
- update shape-circle.svg - update shape-rectangle.svg - add icon while sub-menu is opened
- Line is added - Hover and selection added
- Prettier styles for simple object hover and selection
|
Hi Team, I'm following your progress about Ketcher and I really like all the things around it. I've decided to help a bit, and please have a look at my PR. All the changes are included in the description. Regards, |
|
Dear @JerdoAve , thank you for your help in making our product better. We will review your PR asap. Best regards, |
AndreiMazol
suggested changes
Dec 3, 2020
| @@ -20,6 +20,10 @@ import draw from '../draw' | |||
| import util from '../util' | |||
| import scale from '../../util/scale' | |||
| import Vec2 from 'src/script/util/vec2' | |||
| import { maxHeaderSize } from 'http' | |||
| import { ENGINE_METHOD_PKEY_ASN1_METHS } from 'constants' | |||
There was a problem hiding this comment.
unused imports should be deleted
src/script/util/scale.js
Outdated
| @@ -14,6 +14,8 @@ | |||
| * limitations under the License. | |||
| ***************************************************************************/ | |||
|
|
|||
| import Vec2 from './vec2' | |||
There was a problem hiding this comment.
please delete unused import
|
Dear @JerdoAve , I really appreciate your hard work! All looks great! I see that some my changes were overwritten by mistake so I have reverted them. Looking forward for our further collaboration. Best regards, |
AndreiMazol
approved these changes
Dec 3, 2020
This was
linked to
issues
Dec 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.