#1032 user cannot use Select tool to edit FG opened from file #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-sarkisyan
requested review from
AndreiMazol,
ElenaOdnoshivkina,
ViktoriiaFedotkina and
Alex-Work-Account
karen-sarkisyan
changed the title
karen-sarkisyan
force-pushed
the
#1032-user-cannot-edit-FG-from-file
branch
from
49b16ab to
165c352
Compare
AndreiMazol
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes issue #1032
Worth noting:
select.jswas refactored into a class using TypeScript. Algorithms within methods have not changed significantly.SelectToolis not shown in GitHub due to filename change and changes of the code (mostly indentation though).Reason for refactoring: when file is opened, canvas is redrawn. But 'select' tool in Editor refers to an instance of
ketcher.editor.render.ctabdirectly. Thus, it keeps a reference to an older instance of canvas.This fix makes
editorinstance to be the only source of truth for the tool.Further fixes of other tools are needed. I will create task for it.