Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application hangs after undo action applying to S-Group type changes #975

Closed
AllaZhbanova opened this issue Nov 16, 2021 · 1 comment · Fixed by #978
Closed

Application hangs after undo action applying to S-Group type changes #975

AllaZhbanova opened this issue Nov 16, 2021 · 1 comment · Fixed by #978
Assignees
@AndreiMazol @AllaZhbanova
Milestone
Release 2.3.3

Comments

@AllaZhbanova
Copy link

Steps to Reproduce

  1. Click any structure button from Template pallet on the bottom (example: 'Cyclopentane').
    Click on the canvas
    Select 'Cyclopentane'
    Click the 'S-Group' button and chose Type 'Generic'.
    Select structure
    Click the 'S-Group' button and chose Type 'Multiple Groupe'.
    Click the 'Undo' button.

Expected behavior
Undo action is applied

Actual behavior
Nothing happened. Application hangs

Screenshots

bandicam.2021-11-16.10-58-59-807.mp4

Desktop (please complete the following information):
Chrome Version 93.0.4577.63, Firefox Version 92.0, Microsoft Edge Version 93.0.961.47
@AllaZhbanova AllaZhbanova added this to the Release 2.3.3 milestone Nov 16, 2021
AndreiMazol added a commit that referenced this issue Nov 16, 2021
@AndreiMazol
#975 Application hangs after undo action applying to S-Group type cha…
91b3f71 
…nges

update priority of s-group hierarchy operations
@AndreiMazol AndreiMazol linked a pull request Nov 16, 2021 that will close this issue
#975 Application hangs after undo action applying to S-Group type changes #978
Merged
AndreiMazol added a commit that referenced this issue Nov 16, 2021
@AndreiMazol
#975 Application hangs after undo action applying to S-Group type cha…
f752f14 
…nges (#978)

update priority of s-group hierarchy operations
@AllaZhbanova
Copy link
Author

Fixed, tested v.2.3

AndreiMazol added a commit that referenced this issue Nov 16, 2021
@AndreiMazol
#975 Application hangs after undo action applying to S-Group type cha…
41597e6 
…nges (#978)

update priority of s-group hierarchy operations
# Conflicts:
#	packages/ketcher-core/src/domain/entities/sgroupForest.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@AllaZhbanova AllaZhbanova

Labels
None yet
Projects
None yet
Milestone
Release 2.3.3
Development

Successfully merging a pull request may close this issue.

#975 Application hangs after undo action applying to S-Group type changes epam/ketcher
2 participants
@AndreiMazol @AllaZhbanova