Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save to Templates - Errors are appear when trying to save to templates structure with reaction arrow #821

Closed
vitalgerko opened this issue Oct 5, 2021 · 1 comment · Fixed by #826
Closed

Save to Templates - Errors are appear when trying to save to templates structure with reaction arrow #821

vitalgerko opened this issue Oct 5, 2021 · 1 comment · Fixed by #826
Assignees
@ElenaOdnoshivkina @vitalgerko
Milestone
Release 2.4.0

Comments

@vitalgerko
Copy link

Steps to Reproduce

  1. Launch Ketcher.
  2. Draw any structure with reaction arrow.
  3. Click the 'Save as' button.
  4. Click the 'Save to Templates' button.
  5. Write Template name in the 'Template name' field.
  6. Click the 'Custom template' button.
  7. Click the 'User Templates' folder in the bottom left corner.
  8. Click the 'Edit' button' on the previously drawn structure.

Expected behavior
After Step 4. There are no errors in the browser console.
After Step 8. The drawn structure is displayed in the 'Template edit' window.

Actual behavior
After Step 4. Errors appear in the browser console.
After Step 8. There is no drawn structure in the 'Template edit' window.

Save.to.Templates.-.Errors.are.appear.when.trying.to.save.to.templates.structure.with.reaction.arrow.mp4

Desktop:

OS: Windows 10
Browser: Chrome Version 93.0.4577.63, Firefox Version 92.0, Microsoft Edge Version 93.0.961.47

Additional context
Not reproduce in version 2.3
@vitalgerko vitalgerko added the bug label Oct 5, 2021
@ElenaOdnoshivkina ElenaOdnoshivkina linked a pull request Oct 6, 2021 that will close this issue
#821 Save to Templates - Errors are appear when trying to save to templates structure with reaction arrow and simple object #826
Merged
AndreiMazol pushed a commit that referenced this issue Oct 7, 2021
@ElenaOdnoshivkina
#821 Save to Templates - Errors are appear when trying to save to tem…
42eb8f7 
…plates structure with reaction arrow and simple object (#826)

* add rxnArrows and simpleObjects to attach-template editor

* add text to attach-template editor
@vitalgerko
Copy link
Author

Release/2.4 Closed as fixed.

@AndreiMazol AndreiMazol added this to the Release 2.4.0 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaOdnoshivkina ElenaOdnoshivkina

@vitalgerko vitalgerko

Labels
None yet
Projects
None yet
Milestone
Release 2.4.0
3 participants
@AndreiMazol @ElenaOdnoshivkina @vitalgerko