Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block some tools if they are applied to FG #736

Closed
AndreiMazol opened this issue Aug 30, 2021 · 0 comments · Fixed by #869
Closed

Block some tools if they are applied to FG #736

AndreiMazol opened this issue Aug 30, 2021 · 0 comments · Fixed by #869
Assignees
@r1z3rISGOD @vitalgerko
Labels
enhancement
Milestone
Release 2.4.0

Comments

@AndreiMazol
Copy link
Contributor

AndreiMazol commented Aug 30, 2021 •
edited by r1z3rISGOD
Loading

Some tools should do nothing if they are applied to FG. For details look at #692 AC4.
@AndreiMazol AndreiMazol added this to the Release 2.4.0 milestone Aug 30, 2021
@AndreiMazol AndreiMazol self-assigned this Aug 30, 2021
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
f235308 
…to-FG

# Conflicts:
#	packages/ketcher-react/src/script/editor/tool/apoint.js
#	packages/ketcher-react/src/script/editor/tool/chain.js
#	packages/ketcher-react/src/script/editor/tool/charge.js
#	packages/ketcher-react/src/script/editor/tool/eraser.js
#	packages/ketcher-react/src/script/editor/tool/rgroupatom.js
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
b0f856e 
…to-FG
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
6a16b69 
…to-FG
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
df4bfe4 
…to-FG
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
3ba950c 
…to-FG

# Conflicts:
#	packages/ketcher-core/src/application/editor/operations/sgroup/index.ts
#	packages/ketcher-core/src/domain/entities/functionalGroup.ts
#	packages/ketcher-core/src/domain/entities/struct.ts
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
c00286e 
…to-FG
r1z3rISGOD pushed a commit that referenced this issue Oct 26, 2021
Merge branch 'master' into #736-block-some-tools-if-they-are-applied-…
0205179 
…to-FG

# Conflicts:
#	packages/ketcher-react/src/script/editor/tool/template.js
@r1z3rISGOD r1z3rISGOD linked a pull request Oct 26, 2021 that will close this issue
#736 block some tools if they are applied to FG #869
Merged
AndreiMazol pushed a commit that referenced this issue Oct 27, 2021
@r1z3rISGOD
#736 block some tools if they are applied to FG (#869)
61a6c54 
* Block several tools for FGs

* Block tools if they applied to FG

* Update work with contracted FG

* FG can be deleted by select whole FG struct, sgroups can be created with FGs inside, rgroup tool blocked

* Repair bond tool

* Delete useless blockedEntities

* Rename classes and remove useless reactFC label at RemoveFG component

Co-authored-by: Kirill Kapytov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r1z3rISGOD r1z3rISGOD

@vitalgerko vitalgerko

Labels
enhancement
Projects
None yet
Milestone
Release 2.4.0
Development

Successfully merging a pull request may close this issue.

#736 block some tools if they are applied to FG epam/ketcher
3 participants
@AndreiMazol @r1z3rISGOD @vitalgerko