Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resizing of arrows #698

Closed
AndreiMazol opened this issue Jul 27, 2021 · 2 comments · Fixed by #704 or #708
Closed

Implement resizing of arrows #698

AndreiMazol opened this issue Jul 27, 2021 · 2 comments · Fixed by #704 or #708
Assignees
Milestone

Comments

@AndreiMazol
Copy link
Contributor

This moment all arrows have fixed direction and size.
It is necessary to allow users to change these parameters while adding/updating arrows.

For more details please look at Point 3 in #695 .

@AndreiMazol AndreiMazol added this to the Release 2.4.0 milestone Jul 27, 2021
@AndreiMazol AndreiMazol self-assigned this Jul 27, 2021
@AndreiMazol AndreiMazol changed the title Implement Resizing of Arrows Implement resizing of arrows Jul 27, 2021
@MagomedGasanov MagomedGasanov linked a pull request Aug 4, 2021 that will close this issue
@nseufulina
Copy link

Arrow is displayed incorrectly when file is opened.

The same with all formats, except .ket. (molv2000, molv3000, daylight smiles, extended smiles, cml, smarts formats)

Scenario1

  1. Open
    reaction_dif_prop.zip

Expected result:

Arrow is displayed correctly (default size, position and type)

Actual result:

Arrow is displayed incorrectly.

Scenario2

  1. Create two structures

  2. Choose Arrow Open Angle Tool

  3. Click on the canvas between structures

  4. Save the reaction as in MolV2000 format.

  5. Open saved reaction.

Arrow is displayed correctly (default size, position and type)

Actual result:

Arrow is displayed incorrectly.

Scenario3

  1. Click Open File and paste

C1=CC=CC=C1>>C1=CC=CC=C1

Arrow is displayed correctly (default size, position and type)

Actual result:

Arrow is displayed incorrectly.

Arrow is displayed incorrectly when indigo tools are applied

  1. Create reaction (structures and arrow)
  2. Click Auto-mapping button
    Arrow is displayed correctly (default size, position and type)

Actual result:

Arrow is displayed incorrectly.

The same with other tools: dearomatize, aromatize, clear, lauout, calculate CIP.

@nseufulina nseufulina reopened this Aug 6, 2021
@nseufulina
Copy link

nseufulina commented Aug 6, 2021

Reaction is opened incorrectly when loaded as fragment.

  1. Open reaction file as load as fragment
  2. Click "ok" on the modal window
  3. Click on the canvas
    Expected result:
    No alert in the modal window. Reaction is pasted with arrow
    Actual result:
    step 2 - alert "TypeError: Cannot read property 'add' of undefined".
    step 3 - reaction is pasted without arrow. Reaction is copied as .mol in the Clipboard.

@MagomedGasanov MagomedGasanov linked a pull request Aug 9, 2021 that will close this issue
AndreiMazol pushed a commit that referenced this issue Aug 9, 2021
* Fix open file with reaction

* Fix paste arrows

* Fix adding a template with rxn arrow problem

* Add correct center calculate

* Fix rectangle selection of arrows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants