Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ketcher renders editor twice in dev mode #6375

Closed
rrodionov91 opened this issue Jan 28, 2025 · 0 comments · Fixed by #6373 or #6376
Closed

Ketcher renders editor twice in dev mode #6375

rrodionov91 opened this issue Jan 28, 2025 · 0 comments · Fixed by #6373 or #6376
Assignees
@rrodionov91
Milestone
Ketcher 3.0.0-rc.5

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Create test application that includes Ketcher
  2. Do not enable react strict mode
  3. Insert console.log('Rendered') in Ketcher editor 'onInit' property

Actual behavior
'Rendered' message appears twice

Expected behavior
'Rendered' message appears once

Ketcher version [e.g. v2.4.2].
Ketcher 3.0.0-rc.4

Additional context
This behaviour appears because react Strict mode included into Ketcher Editor component. It needs to remove it from there.
@rrodionov91 rrodionov91 self-assigned this Jan 28, 2025
@rrodionov91 rrodionov91 added this to the Ketcher 3.0.0-rc.5 milestone Jan 28, 2025
@rrodionov91 rrodionov91 linked a pull request Jan 28, 2025 that will close this issue
#6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File #6373
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6370 - Inconsistent zoom behavior when inserting a molecule via setM…
2a668fb 
…olecule and Paste from Clipboard/Open from File (#6373)

* #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File
- added autozoom for setMolecule and addFragment in macro mode

#6375 - Ketcher renders editor twice in dev mode
- removed react strict mode from editor

- updated ketcher to 3.0.0-rc.5
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6370 - Inconsistent zoom behavior when inserting a molecule via setM…
4e239a8 
…olecule and Paste from Clipboard/Open from File (#6373)

* #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File
- added autozoom for setMolecule and addFragment in macro mode

#6375 - Ketcher renders editor twice in dev mode
- removed react strict mode from editor
@rrodionov91 rrodionov91 mentioned this issue Jan 28, 2025
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Jan 28, 2025 that will close this issue
Backmerge: #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File #6376
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 28, 2025
@rrodionov91
#6370 - Inconsistent zoom behavior when inserting a molecule via setM…
7cd4acd 
…olecule and Paste from Clipboard/Open from File (#6373) (#6376)

* #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File
- added autozoom for setMolecule and addFragment in macro mode

#6375 - Ketcher renders editor twice in dev mode
- removed react strict mode from editor
AlexeyGirin pushed a commit that referenced this issue Jan 28, 2025
@rrodionov91 @AlexeyGirin
#6370 - Inconsistent zoom behavior when inserting a molecule via setM…
ef873f3 
…olecule and Paste from Clipboard/Open from File (#6373) (#6376)

* #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File
- added autozoom for setMolecule and addFragment in macro mode

#6375 - Ketcher renders editor twice in dev mode
- removed react strict mode from editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
Ketcher 3.0.0-rc.5
1 participant
@rrodionov91