Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System opens "intellisence"-like dropdown control in unnecessary case #6112

Closed
Tracked by #6600
AlexeyGirin opened this issue Dec 9, 2024 · 1 comment · Fixed by #6158
Closed
Tracked by #6600

System opens "intellisence"-like dropdown control in unnecessary case #6112

AlexeyGirin opened this issue Dec 9, 2024 · 1 comment · Fixed by #6158
Assignees
@kostrubin
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Priority: Low User`s Feedback
Milestone
Ketcher 3.0.0-rc....

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. draw structure on ketcher canvas
  2. Change C1 of a molecule to O using the keyboard and then try to change C2 to N very quickly afterward (even with the cursor over 3. C2) the editor will try to change C2 to "on" even though only N was typed over C2.

Actual behavior
It seems like the quick reassignment of atoms is loading the abbreviation and atom search function even when the user has their cursor over another atom

December.09.2024.-.Birdie.Feedback.mp4

Expected behavior
System should not open "intellisence"-like dropdown if keyboard command was applied to atom

Versions

  • Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
  • Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.109 (Official Build) (64-bit)
  • Win10
@kostrubin kostrubin self-assigned this Dec 11, 2024
kostrubin added a commit that referenced this issue Dec 16, 2024
@kostrubin
#6112 - System opens "intellisence"-like dropdown control in unnecess…
b1117ef 
…ary case
@kostrubin kostrubin linked a pull request Dec 16, 2024 that will close this issue
#6112 - System opens "intellisence"-like dropdown control in unnecessary case #6158
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Dec 17, 2024
@kostrubin @Zhirnoff
#6112 - System opens "intellisence"-like dropdown control in unnecess…
790ef49 
…ary case (#6158)

* #6112 - System opens "intellisence"-like dropdown control in unnecessary case

* - update snapshots
- refactor

* - update snapshots
- refactor

---------

Co-authored-by: Zhirnoff <[email protected]>
@AlexeyGirin
Copy link
Collaborator Author

Verified.

  • Ketcher Version 3.20.0-rc.1 Build at 2024-12-31; 12:50:08
  • Indigo Toolkit Version 1.28.0-rc.1.0-gc167e6266-wasm32-wasm-clang-19.0.0
  • Chrome Version Version 131.0.6778.205 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin mentioned this issue Mar 4, 2025
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostrubin kostrubin

Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Priority: Low User`s Feedback
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
Development

Successfully merging a pull request may close this issue.

#6112 - System opens "intellisence"-like dropdown control in unnecessary case epam/ketcher
2 participants
@kostrubin @AlexeyGirin