Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for all bond types in macromolecules mode #6028

Closed
ljubica-milovic opened this issue Nov 29, 2024 · 1 comment · Fixed by #6181
Closed

Support for all bond types in macromolecules mode #6028

ljubica-milovic opened this issue Nov 29, 2024 · 1 comment · Fixed by #6181
Assignees
@svvald
Labels
Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 3.0.0-rc....

Comments

@ljubica-milovic
Copy link
Collaborator

Background

This is a continuation of a larger "Molecules in Macromolecules mode" issue.

Bond types

There are 14(+2) bond types supported in molecules mode:
image

1 - Single Bond (supported in macromolecules mode already);
2 - Double Bond (supported in macromolecules mode already);
3 - Triple Bond;
4 - Any Bond;
5 - Aromatic Bond (one representation);
6 - Single/Double Bond;
7 - Single/Aromatic Bond;
8 - Double/Aromatic Bond;
9 - Dative Bond;
10 - Hydrogen Bond;
11 - Single Up Bond (supported in macromolecules mode already);
12 - Single Down Bond (supported in macromolecules mode already);
13 - Single Up/Down Bond (supported in macromolecules mode, but incorrectly - as a simple single bond);
14 - Double Cis/Trans Bond (supported in macromolecules mode, but incorrectly - as a simple double bond);
15 - Aromatic Bond (one representation);
16 - Thick foreground bond (an up bond surrounded by wide ends of other up bonds).

Requirements

  1. Small molecules form molecules mode with any bond type should not change their representation when user switcher to macromolecules mode.

  2. Structures with all kinds of bond types should be properly exported and imported as part of monomer-molecule structures.
@ljubica-milovic ljubica-milovic added feature request Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Nov 29, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Dec 2, 2024
@svvald svvald self-assigned this Dec 16, 2024
svvald added a commit that referenced this issue Dec 20, 2024
@svvald
#6028 – Support all remaining types of bond from small molecules mode…
8f2b730 
… in macro molecules mode
@svvald svvald linked a pull request Dec 20, 2024 that will close this issue
#6028 – Support all remaining types of bond from small molecules mode in macro molecules mode #6181
Merged
9 tasks
svvald added a commit that referenced this issue Dec 20, 2024
@svvald
#6028 – Support all remaining types of bond from small molecules mode…
77414e8 
… in macro molecules mode
svvald added a commit that referenced this issue Dec 20, 2024
@svvald
#6028 – Change Up/Down bond appearance, update UI tests
56315d2
svvald added a commit that referenced this issue Dec 24, 2024
@svvald
#6028 – Support all remaining types of bond from small molecules mode…
22f79fa 
… in macro molecules mode
svvald added a commit that referenced this issue Dec 24, 2024
@svvald
#6028 – Change Up/Down bond appearance, update UI tests
6f65be2
svvald added a commit that referenced this issue Dec 24, 2024
@svvald
#6028 – Resolve merge conflicts, fix UI tests
d9a126c
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6028 – Support all remaining types of bond from small molecules mode…
0e0cba0 
… in macro molecules mode
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6028 – Change Up/Down bond appearance, update UI tests
d0a92bb
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6028 – Resolve merge conflicts, fix UI tests
813bb9f
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6028 – Increase monomers locator index by 1 caused by added arrow ma…
18eb949 
…rker <use> tag
svvald added a commit that referenced this issue Dec 25, 2024
@svvald
#6028 – Increase monomers locator index by 1 caused by added arrow ma…
b2eef8b 
…rker <use> tag
svvald added a commit that referenced this issue Dec 27, 2024
@svvald
#6028 – Increase monomers locator index by 1 caused by added arrow ma…
b7c59f3 
…rker <use> tag
svvald added a commit that referenced this issue Dec 27, 2024
@svvald
#6028 – Support all remaining types of bond from small molecules mode…
e3e55bf 
… in macro molecules mode (#6181)

* #6028 – Support all remaining types of bond from small molecules mode in macro molecules mode

* #6028 – Change Up/Down bond appearance, update UI tests

* #6028 – Resolve merge conflicts, fix UI tests

* #6028 – Increase monomers locator index by 1 caused by added arrow marker <use> tag
This was referenced Jan 6, 2025
Open
Open
Open
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 3.20.0-rc.1 Build at 2024-12-31; 12:50:08
  • Indigo Toolkit Version 1.28.0-rc.1.0-gc167e6266-wasm32-wasm-clang-19.0.0
  • Chrome Version Version 131.0.6778.205 (Official Build) (64-bit)
  • Win10

This was referenced Jan 20, 2025
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
4 participants
@svvald @AlexeyGirin @Zhirnoff @ljubica-milovic