Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Copy to Clipboard" to the export window #5854

Closed
ljubica-milovic opened this issue Oct 24, 2024 · 2 comments · Fixed by #5956
Closed

Add "Copy to Clipboard" to the export window #5854

ljubica-milovic opened this issue Oct 24, 2024 · 2 comments · Fixed by #5956
Assignees
@mnmsvlw
Labels
Requirements Done Test Cases Written Test cases has been written for that issue Usability
Milestone
Ketcher 2.28.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Oct 24, 2024 •
edited by Andrey-Antonov
Loading

Background
Many times, especially for "simpler" and linear formats like SMILES, FASTA, and HELM, the user does not need a file to be created, but rather the information to be copied to the clipboard so that they can paste it somewhere.

Requirements

  1. In both molecules mode and macromolecules mode, an icon should be added to the export window - "Copy to Clipboard".
  2. The icon should appear in the top right corner of the preview section of the export windows (see mockups).
  3. When the user clicks on the preview section the icon should disappear.
  4. When the user hovers over the are where the icon should be (after they've clicked somewhere in the preview area), the button should appear again.
  5. Tooltip should appear on hover over the icon "Copy to Clipboard".
  6. When clicked, all the information that would get exported to a file gets copied to the clipboard.

UX
TBD
for dev
@ljubica-milovic ljubica-milovic added this to the Ketcher 2.28.0-rc.1 milestone Oct 25, 2024
@Zhirnoff
Copy link
Collaborator

@NataliaLoginova @mnmsvlw Please add a test-id to this button during the development phase, if possible. This will make automation easier for us.

@Zhirnoff Zhirnoff changed the title Add "Copy to Clapboard" to the export window Add "Copy to Clipboard" to the export window Nov 11, 2024
mnmsvlw added a commit that referenced this issue Nov 11, 2024
@mnmsvlw
#5854 - Add copy to clipboard to the export window
c2c6993
@mnmsvlw mnmsvlw linked a pull request Nov 11, 2024 that will close this issue
#5854 – Add "Copy to Clipboard" to the export window #5956
Merged
9 tasks
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Nov 12, 2024
NataliaLoginova pushed a commit that referenced this issue Nov 15, 2024
@mnmsvlw
#5854 – Add "Copy to Clipboard" to the export window (#5956)
990ddbf 
* #5854 - Add copy to clipboard to the export window

* Update unit test snapshots

* Disable auto selection in the macromolecules mode export window

* Update test screenshots
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2024

 Tested.
2024-12-06_11h44_58
2024-12-06_11h46_30

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.1]
Indigo version
[Version 1.27.0-rc.1]

@Zhirnoff Zhirnoff mentioned this issue Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
Requirements Done Test Cases Written Test cases has been written for that issue Usability
Projects
None yet
Milestone
Ketcher 2.28.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5854 – Add "Copy to Clipboard" to the export window epam/ketcher
3 participants
@Zhirnoff @mnmsvlw @ljubica-milovic