Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Abbreviation dialog not appear when click by Erase tool on Expanded Macromolecule, R1 and R2 attachment points appear instead #5665

Closed
Zhirnoff opened this issue Oct 7, 2024 · 1 comment · Fixed by #5770 or #5830
Closed

Edit Abbreviation dialog not appear when click by Erase tool on Expanded Macromolecule, R1 and R2 attachment points appear instead #5665

Zhirnoff opened this issue Oct 7, 2024 · 1 comment · Fixed by #5770 or #5830
Assignees
@svvald
Labels
Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Milestone
Ketcher 2.26.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 7, 2024 •
edited
Loading

Steps to Reproduce

  1. Open file in Macro mode (Flex mode) monomers-cycled.zip
  2. Switch to Micro mode
  3. Select Erase tool
  4. Expand any abbreviation and click on it

Actual behavior
Edit Abbreviation dialog not appear when click by Erase tool on Expanded Macromolecule, , R1 and R2 attachment points appear on the expanded structure. Additionally, after this action, hovering over the structure no longer displays the bounding box, making further interactions challenging.

Expected behavior
Edit Abbreviation dialog should appear when click by Erase tool on Expanded Macromolecule

Videos

2024-10-07_16h13_38.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]
Bug found during testing: #5400
@Zhirnoff Zhirnoff added bug Priority: High Macro-Micro Bucket: Macro-Micro View related issues labels Oct 7, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@Zhirnoff Zhirnoff changed the title Expanded macromolecule abbreviation in Micro mode is not erased, R1 and R2 attachment points appear instead Edit Abbreviation dialog not appear when click by Erase tool on Expanded Macromolecule, R1 and R2 attachment points appear instead Oct 7, 2024
@svvald svvald self-assigned this Oct 15, 2024
svvald added a commit that referenced this issue Oct 16, 2024
@svvald
#5665 – Show remove abbreviation dialog when trying to erase expanded…
f165f5c 
… monomer
svvald added a commit that referenced this issue Oct 17, 2024
@svvald
#5665 – Show remove abbreviation dialog when trying to erase expanded…
a79f978 
… monomer
svvald added a commit that referenced this issue Oct 17, 2024
@svvald
#5665 – Show remove abbreviation dialog when trying to erase expanded…
fe3487e 
… monomer (#5770)
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-10-21_16h27_06.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.4]
Indigo version
[Version 1.25.0-rc.2]

@svvald svvald linked a pull request Oct 21, 2024 that will close this issue
#5665 – Show remove abbreviation dialog when trying to erase expanded monomer #5770
Merged
9 tasks
svvald added a commit that referenced this issue Oct 21, 2024
@svvald
Backmerge: #5665 – Show remove abbreviation dialog when trying to era…
e2e2d17 
…se expanded monomer
@svvald svvald linked a pull request Oct 21, 2024 that will close this issue
Backmerge: #5665 – Show remove abbreviation dialog when trying to erase expanded monomer #5830
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 22, 2024
@svvald
Backmerge: #5665 – Show remove abbreviation dialog when trying to era…
41fc18a 
…se expanded monomer (#5830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Projects
None yet
Milestone
Ketcher 2.26.0-rc.4
4 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff