Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The atom is not completely colored #5597

Closed
AnnaKosol opened this issue Sep 27, 2024 · 1 comment · Fixed by #5643 or #5719
Closed

The atom is not completely colored #5597

AnnaKosol opened this issue Sep 27, 2024 · 1 comment · Fixed by #5643 or #5719
Assignees
@aproskurnov
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium Team G
Milestone
Ketcher 2.26.0-rc.2

Comments

@AnnaKosol
Copy link
Contributor

Steps to Reproduce

  1. highlight an atom
  2. choose highlight in the menu
  3. click to one color

Actual behavior
Снимок экрана 2024-09-27 в 16 06 06

Expected behavior
Снимок экрана 2024-09-27 в 16 06 21

Desktop (please complete the following information):

Issues found while testing #4984
@NataliaLoginova NataliaLoginova removed their assignment Oct 3, 2024
@AlexanderSavelyev AlexanderSavelyev added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@AnnaKosol AnnaKosol changed the title Preview: Atom is not completely colored The atom is not completely colored Oct 7, 2024
@AlexeyGirin AlexeyGirin added Team G Micromolecules canvas Bucket: Micromolecules canvas related issues labels Oct 8, 2024
@aproskurnov aproskurnov linked a pull request Oct 10, 2024 that will close this issue
Backmerge: #5597 - change rendering of highlights #5643
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 10, 2024
@aproskurnov
#5597 - change rendering of highlights (#5643)
3bf428e 
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

---------

Co-authored-by: Aleksei Proskurnov <[email protected]>
aproskurnov added a commit that referenced this issue Oct 10, 2024
@aproskurnov
#5597 - change rendering of highlights (#5643)
4efcbfe 
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

---------

Co-authored-by: Aleksei Proskurnov <[email protected]>
NataliaLoginova pushed a commit that referenced this issue Oct 11, 2024
@aproskurnov
#5597 - change rendering of highlights (#5643) (#5719)
dc8acb8 
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

---------

Co-authored-by: Aleksei Proskurnov <[email protected]>
rrodionov91 pushed a commit that referenced this issue Oct 13, 2024
@aproskurnov @rrodionov91
#5597 - change rendering of highlights (#5643)
672738a 
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

---------

Co-authored-by: Aleksei Proskurnov <[email protected]>
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

@NataliaLoginova NataliaLoginova mentioned this issue Oct 16, 2024
Merged
9 tasks
@aproskurnov aproskurnov linked a pull request Oct 17, 2024 that will close this issue
#5597 New rendering for highlight #5719
Merged
9 tasks
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@aproskurnov @Guch1g0v
#5597 - change rendering of highlights (#5643)
db4850d 
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

---------

Co-authored-by: Aleksei Proskurnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium Team G
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
5 participants
@aproskurnov @AlexanderSavelyev @NataliaLoginova @AlexeyGirin @AnnaKosol