Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom in macromolecules mode should be in relation to the top left corner of the structures #5590

Closed
ljubica-milovic opened this issue Sep 26, 2024 · 1 comment · Fixed by #5845
Closed

Zoom in macromolecules mode should be in relation to the top left corner of the structures #5590

ljubica-milovic opened this issue Sep 26, 2024 · 1 comment · Fixed by #5845
Assignees
@rrodionov91
Labels
Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.27.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Sep 26, 2024 •
edited by rrodionov91
Loading

Background
Currently, if the user zooms in (not using the hotkeys) the zooming in happens in the relation to the center of the canvas/screen, and that sometimes results in the disappearance of the sequence from the view. This ticket addresses that issue by zooming in the relation of the top left corner of the sequence(s).

Requirement

  • When the user zooms in (using the Ctrl+,Ctrl- hotkeys or via buttons on top toolbar), the zooming in should be in relation to the most top and most left monomer on canvas.

Examples

image
image
image
@ljubica-milovic ljubica-milovic added this to the Ketcher 2.27.0-rc.1 milestone Oct 1, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 23, 2024
rrodionov91 added a commit that referenced this issue Oct 23, 2024
@rrodionov91
#5590 - Zoom in macromolecules mode should be in relation to the top …
7a02ed5 
…left corner of the structures
@rrodionov91 rrodionov91 linked a pull request Oct 23, 2024 that will close this issue
#5590 - Zoom in macromolecules mode should be in relation to the top left corner of the structures #5845
Merged
9 tasks
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Oct 24, 2024
rrodionov91 added a commit that referenced this issue Oct 24, 2024
@rrodionov91
#5590 - Zoom in macromolecules mode should be in relation to the top …
e2e724b 
…left corner of the structures
rrodionov91 added a commit that referenced this issue Oct 24, 2024
@rrodionov91
#5590 - Zoom in macromolecules mode should be in relation to the top …
afb595a 
…left corner of the structures
rrodionov91 added a commit that referenced this issue Oct 25, 2024
@rrodionov91
#5590 - Zoom in macromolecules mode should be in relation to the top …
66df062 
…left corner of the structures (#5845)

- added time reporter for playwrite
- updated screenshots
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 6, 2024

Tested

2024-11-06_16h34_30.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.27.0-rc.1]
Indigo version
[Version 1.26.0-rc.1]

@AlexeyGirin AlexeyGirin mentioned this issue Nov 11, 2024
Closed
7 tasks
@AlexeyGirin AlexeyGirin mentioned this issue Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.27.0-rc.1
3 participants
@rrodionov91 @Zhirnoff @ljubica-milovic