Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling between Flex and Sequence modes causes loosing layout info #5372

Closed
AlexeyGirin opened this issue Aug 27, 2024 · 1 comment · Fixed by #5616
Closed

Toggling between Flex and Sequence modes causes loosing layout info #5372

AlexeyGirin opened this issue Aug 27, 2024 · 1 comment · Fixed by #5616
Assignees
@mnmsvlw
Labels
Flex mode Bucket: Flex canvas related mode Priority: High Sequence mode Bucket: Sequence mode related issues User`s Feedback
Milestone
Ketcher 2.27.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macromolecules mode - Flex mode
  2. Load from file: System should remember the canvas mode on Molecules_Macromolecules mode switch (do not switch to Sequernce by default).zip
    image
  3. Toggle to Sequence mode
  4. Toggle back to Flex mode

Actual behavior
System lost layout info
image

Expected behavior
System keeps layout info
image

Versions

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:06:32
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-x86_64-linux-gnu-11.2.1
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added bug Priority: High User`s Feedback Sequence mode Bucket: Sequence mode related issues Flex mode Bucket: Flex canvas related mode labels Aug 27, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.1 milestone Aug 27, 2024
@mnmsvlw mnmsvlw self-assigned this Sep 30, 2024
mnmsvlw added a commit that referenced this issue Oct 1, 2024
@mnmsvlw
#5372 - toggling between flex and sequence modes causes loosing layou…
62099fe 
…t info
@mnmsvlw mnmsvlw linked a pull request Oct 1, 2024 that will close this issue
#5372 – Toggling between Flex and Sequence modes causes loosing layout info #5616
Merged
9 tasks
mnmsvlw added a commit that referenced this issue Oct 2, 2024
@mnmsvlw
#5372 - enable sequence mode layout recalculation only after sequence…
858bdeb 
… update
mnmsvlw added a commit that referenced this issue Oct 22, 2024
@mnmsvlw
#5372 - toggling between flex and sequence modes causes loosing layou…
1a317ad 
…t info
mnmsvlw added a commit that referenced this issue Oct 22, 2024
@mnmsvlw
#5372 - enable sequence mode layout recalculation only after sequence…
15c2bf7 
… update
mnmsvlw added a commit that referenced this issue Oct 27, 2024
@mnmsvlw
#5372 - toggling between flex and sequence modes causes loosing layou…
0f3567f 
…t info
mnmsvlw added a commit that referenced this issue Oct 27, 2024
@mnmsvlw
#5372 - enable sequence mode layout recalculation only after sequence…
8cd59ab 
… update
mnmsvlw added a commit that referenced this issue Oct 29, 2024
@mnmsvlw
#5372 - toggling between flex and sequence modes causes loosing layou…
18eef90 
…t info
mnmsvlw added a commit that referenced this issue Oct 29, 2024
@mnmsvlw
#5372 - enable sequence mode layout recalculation only after sequence…
7146cf2 
… update
NataliaLoginova pushed a commit that referenced this issue Oct 29, 2024
@mnmsvlw
#5372 – Toggling between Flex and Sequence modes causes loosing layou…
08e1d57 
…t info (#5616)

* #5372 - toggling between flex and sequence modes causes loosing layout info

* #5372 - enable sequence mode layout recalculation only after sequence update

* Fix bug

* Update monomer position

* Update scrolling condition

* Update screenshots

* Update failed test screenshots

* Update screenshots

* Update sequence mode screenshot

* Resolve merge conflicts
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

@ljubica-milovic ljubica-milovic mentioned this issue Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
Flex mode Bucket: Flex canvas related mode Priority: High Sequence mode Bucket: Sequence mode related issues User`s Feedback
Projects
None yet
Milestone
Ketcher 2.27.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5372 – Toggling between Flex and Sequence modes causes loosing layout info epam/ketcher
3 participants
@rrodionov91 @AlexeyGirin @mnmsvlw