Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System should remember the canvas mode on Molecules/Macromolecules mode switch (do not switch to Sequernce by default) #5370

Closed
AlexeyGirin opened this issue Aug 27, 2024 · 1 comment · Fixed by #5631
Closed

System should remember the canvas mode on Molecules/Macromolecules mode switch (do not switch to Sequernce by default) #5370

AlexeyGirin opened this issue Aug 27, 2024 · 1 comment · Fixed by #5631
Assignees
@mnmsvlw
Labels
Flex mode Bucket: Flex canvas related mode Macro-Micro Bucket: Macro-Micro View related issues Priority: High User`s Feedback
Milestone
Ketcher 2.27.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macromolecules mode - Flex mode
  2. Load from file: System should remember the canvas mode on Molecules_Macromolecules mode switch (do not switch to Sequernce by default).zip
    image
  3. Toggle to Molecules mode
  4. Toggle back to Macromolecules mode

Actual behavior
System opens Sequence mode canvas
image

Expected behavior
System opens Flex mode canvas
image
In other words - system should memorize the canvas mode before switching to Molecules and open it back on return to Macromolecules

Versions

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:06:32
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-x86_64-linux-gnu-11.2.1
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added bug User`s Feedback Macro-Micro Bucket: Macro-Micro View related issues labels Aug 27, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.1 milestone Aug 27, 2024
@AlexeyGirin AlexeyGirin added Flex mode Bucket: Flex canvas related mode Priority: High labels Aug 27, 2024
@mnmsvlw mnmsvlw self-assigned this Oct 1, 2024
mnmsvlw added a commit that referenced this issue Oct 3, 2024
@mnmsvlw
#5370 - System should remember the canvas mode on moleculesmacromolec…
1db4312 
…ules mode switch do not switch to sequernce by default
@mnmsvlw mnmsvlw linked a pull request Oct 3, 2024 that will close this issue
#5370 – System should remember the canvas mode on Molecules/Macromolecules mode switch (do not switch to Sequernce by default) #5631
Merged
9 tasks
mnmsvlw added a commit that referenced this issue Oct 21, 2024
@mnmsvlw
#5370 - System should remember the canvas mode on moleculesmacromolec…
a1448bd 
…ules mode switch do not switch to sequernce by default
mnmsvlw added a commit that referenced this issue Oct 22, 2024
@mnmsvlw
#5370 - System should remember the canvas mode on moleculesmacromolec…
f2add9b 
…ules mode switch do not switch to sequernce by default
NataliaLoginova pushed a commit that referenced this issue Oct 22, 2024
@mnmsvlw
#5370 – System should remember the canvas mode on Molecules/Macromole…
0576797 
…cules mode switch (do not switch to Sequernce by default) (#5631)

* #5370 - System should remember the canvas mode on moleculesmacromolecules mode switch do not switch to sequernce by default

* Fix bug and update screenshots

* Update screenshot

* Update unstable test and screenshot

* Update tests and screenshots

* Update screenshots
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 6, 2024

Tested. Bug fixed.

2024-11-06_18h05_37.mp4
2024-11-06_18h06_59.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.27.0-rc.1]
Indigo version
[Version 1.26.0-rc.1]

@ljubica-milovic ljubica-milovic mentioned this issue Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
Flex mode Bucket: Flex canvas related mode Macro-Micro Bucket: Macro-Micro View related issues Priority: High User`s Feedback
Projects
None yet
Milestone
Ketcher 2.27.0-rc.1
5 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @mnmsvlw and others