Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new hash spacing setting to canvas #5354

Closed
accmeboot opened this issue Aug 23, 2024 · 1 comment · Fixed by #5816
Closed

Apply new hash spacing setting to canvas #5354

accmeboot opened this issue Aug 23, 2024 · 1 comment · Fixed by #5816
Assignees
@Guch1g0v
Labels
ACS standard phase III Team G
Milestone
Ketcher 2.27.0-rc.1

Comments

@accmeboot
Copy link
Collaborator

accmeboot commented Aug 23, 2024 •
edited by AlekseiKhariukov
Loading

Apply the new hash spacing setting to ketcher canvas.

Background
To fully comply with the ACS style, the "Hash spacing" setting need to be added (done in Related task)

Solution
Adjust the the distance between lines of a Single Down Bond (only applies to this bond);
Image

Update: The bond should contain at least four hashes. If the hash spacing does not allow for four hashes, the setting can be ignored.
@accmeboot accmeboot self-assigned this Aug 23, 2024
@AlexanderSavelyev AlexanderSavelyev added this to the Ketcher 2.27.0-rc.1 milestone Oct 7, 2024
@Guch1g0v Guch1g0v linked a pull request Oct 18, 2024 that will close this issue
#5354 - Apply new hash spacing setting to canvas #5816
Merged
9 tasks
@Guch1g0v Guch1g0v removed a link to a pull request Oct 18, 2024
#5354 - Apply new hash spacing setting to canvas #5816
Merged
9 tasks
@Guch1g0v Guch1g0v linked a pull request Oct 18, 2024 that will close this issue
#5354 - Apply new hash spacing setting to canvas #5816
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 21, 2024
@Guch1g0v
#5354 - Apply new hash spacing setting to canvas (#5816)
e987c98 
* #5434 - Apply new hash spacing setting to canvas

* feat: add minimum lines for large hash spacing

* fix: add dedicated function for converting hash spacing to pixels

* fix: change check hash spacing condition

* update snapshots
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
ACS standard phase III Team G
Projects
None yet
Milestone
Ketcher 2.27.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5354 - Apply new hash spacing setting to canvas epam/ketcher
5 participants
@AlexanderSavelyev @NataliaLoginova @accmeboot @AlexeyGirin @Guch1g0v