Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing all monomers (or part of them) in edit mode - works wrong - system cuts sequence on two #5341

Closed
Tracked by #6600
AlexeyGirin opened this issue Aug 22, 2024 · 2 comments · Fixed by #6226
Closed
Tracked by #6600

Replacing all monomers (or part of them) in edit mode - works wrong - system cuts sequence on two #5341

AlexeyGirin opened this issue Aug 22, 2024 · 2 comments · Fixed by #6226
Assignees
@tanas80
Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Test Automation affected That issue affect on existed auto test, please update screenshots after fix
Milestone
Ketcher 3.0.0-rc....

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load from file: Replacing all monomers (or part of them) in edit mode - works wrong - system cuts sequence on two.zip
    image
  3. Select three @ symbols in edit mode (having blinking cursor somewhere in the middle of sequence - this is important!
    image
  4. Click any monomer from the library (C peptide in my case) - click Yes in appeared Confirm Your Action dialog

Actual behavior
System cuts sequence on two
image

Expected behavior
Sequence remain solid, replacement is done
image

Versions

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:06:32
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-x86_64-linux-gnu-11.2.1
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Related issue - #4878
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues labels Aug 22, 2024
@Drimodaren Drimodaren self-assigned this Dec 11, 2024
@AlexeyGirin AlexeyGirin added the Test Automation affected That issue affect on existed auto test, please update screenshots after fix label Dec 17, 2024
@Drimodaren Drimodaren removed their assignment Dec 20, 2024
@tanas80 tanas80 self-assigned this Dec 24, 2024
@tanas80
Copy link
Collaborator

tanas80 commented Dec 26, 2024

It is enough to replace the first monomer only with the caret placed after the second monomer or farther.
Ketcher-5341 2024-12-26

tanas80 added a commit that referenced this issue Dec 28, 2024
@tanas80
#5341: Fix SequenceMode to prevent break in two on insert
f7fc4e5
@tanas80 tanas80 mentioned this issue Dec 30, 2024
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Dec 30, 2024
@tanas80
#5341: Fix SequenceMode to prevent break in two on insert (#6226)
c9b45af
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 3, 2025

Tested. Bug fixed.
2025-01-03_12h26_29

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.0.0-rc.1]
Indigo version
[Version 1.28.0-rc.1]

@AlexeyGirin AlexeyGirin mentioned this issue Mar 4, 2025
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanas80 tanas80

Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Test Automation affected That issue affect on existed auto test, please update screenshots after fix
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
5 participants
@tanas80 @rrodionov91 @AlexeyGirin @Zhirnoff @Drimodaren