Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation preset without phosphate causes R3less sugars disabled in the library FOREVER #5313

Closed
AlexeyGirin opened this issue Aug 19, 2024 · 1 comment · Fixed by #5475 or #5489
Closed

Creation preset without phosphate causes R3less sugars disabled in the library FOREVER #5313

AlexeyGirin opened this issue Aug 19, 2024 · 1 comment · Fixed by #5475 or #5489
Assignees
@rrodionov91
Labels
Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Go to Library and click New preset
  3. Go to Sugars section and click any sugar (R - in my cases)
  4. Go to Bases section and click any base (A - in my case)
  5. Click Add to Presets button
  6. Open Sugars section

Actual behavior
Sugars without R3 are disabled
image

Expected behavior
All sugars are enabled.
image

Versions

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:06:32
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-x86_64-linux-gnu-11.2.1
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Related issue - #4878
@AlexeyGirin AlexeyGirin added bug Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues labels Aug 19, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 10, 2024
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5313 - Creation preset without phosphate causes R3less sugars disabl…
0f25a27 
…ed in the library FOREVER

- added clearing of rna components validations in case of NOT edit mode
@rrodionov91 rrodionov91 linked a pull request Sep 10, 2024 that will close this issue
#5313 - Creation preset without phosphate causes R3less sugars disabled in the library FOREVER #5475
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5313 - Creation preset without phosphate causes R3less sugars disabl…
ebf6c4c 
…ed in the library FOREVER

- added clearing of rna components validations in case of NOT edit mode
@rrodionov91 rrodionov91 linked a pull request Sep 11, 2024 that will close this issue
Backmerge: #5313 - Creation preset without phosphate causes R3less sugars disabled in the library FOREVER #5489
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5313 - Creation preset without phosphate causes R3less sugars disabl…
0df23ea 
…ed in the library FOREVER (#5475)

- added clearing of rna components validations in case of NOT edit mode
rrodionov91 added a commit that referenced this issue Sep 12, 2024
@rrodionov91
Backmerge: #5313 - Creation preset without phosphate causes R3less su…
7ac5b41 
…gars disabled in the library FOREVER (#5489)

- added clearing of rna components validations in case of NOT edit mode
- refactored rna builder validation
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-09-16_15h53_29

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.2]
Indigo version
[Version 1.24.0-rc.2]

@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue Sep 19, 2024
Closed
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5313 - Creation preset without phosphate causes R3less su…
0f33195 
…gars disabled in the library FOREVER (#5489)

- added clearing of rna components validations in case of NOT edit mode
- refactored rna builder validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff