Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New preset creation process intefere with monomer replacement on the sequence mode #5301

Closed
AlexeyGirin opened this issue Aug 15, 2024 · 1 comment · Fixed by #5304
Closed

New preset creation process intefere with monomer replacement on the sequence mode #5301

AlexeyGirin opened this issue Aug 15, 2024 · 1 comment · Fixed by #5304
Assignees
@svvald
Labels
Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Go to Library and click New preset
  3. Go to Sugar section and click any sugar (R - in my cases)
  4. Go to Phosphate section and click and phosphate (P - in my case)
  5. Click Add to Presets button

Actual behavior
System creates new preset (this is ok) and adds monomer symbol on the sequence:
image

Expected behavior
Canvas remains blank, System creates new preset
image

Versions

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Related issue - #4878
@AlexeyGirin AlexeyGirin added bug Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues labels Aug 15, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.3 milestone Aug 15, 2024
@AlexeyGirin AlexeyGirin mentioned this issue Aug 15, 2024
Closed
svvald added a commit that referenced this issue Aug 16, 2024
@svvald
#5301 – New preset creation process interferes with monomer replaceme…
84afd8c 
…nt on the sequence mode
@svvald svvald self-assigned this Aug 16, 2024
@svvald svvald linked a pull request Aug 16, 2024 that will close this issue
#5301 – New preset creation process interferes with monomer replacement on the sequence mode #5304
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Aug 16, 2024
@svvald
#5301 – New preset creation process interferes with monomer replaceme…
4843553 
…nt on the sequence mode (#5304)
@svvald svvald closed this as completed Aug 20, 2024
svvald added a commit that referenced this issue Aug 20, 2024
@svvald
Backmerge: #5301 – New preset creation process interferes with monome…
6398bb5 
…r replacement on the sequence mode (#5304)
svvald added a commit that referenced this issue Aug 20, 2024
@svvald
Backmerge: #5301 – New preset creation process interferes with monome…
10fb6ca 
…r replacement on the sequence mode (#5304) (#5328)
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Aug 20, 2024 •
edited
Loading

Fixed.
image

  • Ketcher Version 2.24.0-rc.3 Build at 2024-08-20; 13:16:59
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.120 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@svvald @Guch1g0v
Backmerge: #5301 – New preset creation process interferes with monome…
a75234c 
…r replacement on the sequence mode (#5304) (#5328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
Priority: High RNA Builder Bucket: RNA builder related issues Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.3
2 participants
@svvald @AlexeyGirin