Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) #5228

Closed
AlexeyGirin opened this issue Aug 7, 2024 · 1 comment · Fixed by #5277 or #5279
Closed

System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) #5228

AlexeyGirin opened this issue Aug 7, 2024 · 1 comment · Fixed by #5277 or #5279
Assignees
@rrodionov91
Labels
Monomer Library Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 7, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Go to the Library - Peptide tab
  3. Click on A peptide twice to put two As on the canvas
    image
  4. Click on DACys peptide (C section, it has no R1 connection point)

Actual behavior
System split existed sequence on two and adds monomer at the beginning on the second one. And shows error message
image

Expected behavior

  1. No monomers should be added.
    As per requirement:

.....2.2 If monomer being added lacks AP necessary for establishing connections then error message should be displayed and no monomer is added.

  1. Error message text should be The monomer lacks R1 connection point and cannot be inserted at current position
    image

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.2 milestone Aug 7, 2024
@AlexeyGirin AlexeyGirin changed the title Systen insert monomer from the library to the canvas even if it shouldn't Systen insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) Aug 7, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 9, 2024
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#5228 - Systen insert monomer from the library to the canvas even if …
d3d090c 
…it shouldn't (and error message is wrong)

- fixed case with adding new sequence items using replace from library in case if there is no attachment points
@rrodionov91 rrodionov91 changed the title Systen insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) Systeь insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) Aug 9, 2024
@rrodionov91 rrodionov91 changed the title Systeь insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) Aug 9, 2024
@rrodionov91 rrodionov91 linked a pull request Aug 9, 2024 that will close this issue
#5228 - System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) #5277
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
#5228 - Systen insert monomer from the library to the canvas even if …
dfc77d3 
…it shouldn't (and error message is wrong)

- fixed case with adding new sequence items using replace from library in case if there is no attachment points
@rrodionov91 rrodionov91 linked a pull request Aug 12, 2024 that will close this issue
Backmerge: #5228 - System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) #5279
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
#5228 - System insert monomer from the library to the canvas even if …
412b7c1 
…it shouldn't (and error message is wrong) (#5277)

- fixed case with adding new sequence items using replace from library in case if there is no attachment points
- fixed R1/R2 missed attachment points cases
rrodionov91 added a commit that referenced this issue Aug 12, 2024
@rrodionov91
Backmerge: #5228 - System insert monomer from the library to the canv…
d8f6024 
…as even if it shouldn't (and error message is wrong) (#5279)

- fixed case with adding new sequence items using replace from library in case if there is no attachment points
- fixed R1/R2 missed attachment points cases
@AlexeyGirin
Copy link
Collaborator Author

Partially fixed.
No monomer insertion happens but error message is wrong.
Follow up bug has been created: #5300

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5228 - System insert monomer from the library to the canv…
196d781 
…as even if it shouldn't (and error message is wrong) (#5279)

- fixed case with adding new sequence items using replace from library in case if there is no attachment points
- fixed R1/R2 missed attachment points cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Monomer Library Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin