Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting new sequences with "Plus" icon on canvas #4887

Closed
olganaz opened this issue Jun 26, 2024 · 1 comment · Fixed by #5173
Closed

Starting new sequences with "Plus" icon on canvas #4887

olganaz opened this issue Jun 26, 2024 · 1 comment · Fixed by #5173
Assignees
@rrodionov91
Labels
Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Jun 26, 2024 •
edited by ljubica-milovic
Loading

Background
The current method of starting a new sequence with a right-click in sequence mode is not intuitive for users. An explicit UX approach that clearly indicates how to start a new chain should be implemented.

Requirements
QUOTED REQUIREMENT ARE NO LONGER VALID

  1. If the canvas is empty in sequence mode the "plus" icon should be displayed in top left corner of the visual area.
    image
  2. When hovering on the "plus" button it should change the color.
    image
  1. (In both view and edit modes) Hovering above the first sequence, between two sequences and bellow the last sequence (32 px), should give the user the following visual element:
    image
  2. Clicking on the "plus" buttons should result in turning on of editing mode (if the user was in view mode) and displaying of a grid. The grid should start at the same location as the plus button, with the cursor automatically placed in the first cell of that line.
  3. If two sequences have at least one sidechain correction, the "plus" button between them should be absent.
    (image for better understanding)
    image
@olganaz olganaz added this to the Ketcher 2.24.0-rc.1 milestone Jun 26, 2024
@olganaz olganaz added the draft label Jun 26, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jul 8, 2024
rrodionov91 added a commit that referenced this issue Jul 25, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas
de948eb 
#5136 - Starting new sequence by typing in sequence mode
@rrodionov91 rrodionov91 linked a pull request Jul 25, 2024 that will close this issue
#4887 - Starting new sequences with "Plus" icon on canvas #5173
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas
de38d91 
#5136 - Starting new sequence by typing in sequence mode
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4887 - Starting new sequences with "Plus" icon on canvas (#5173)
93f7b05 
* #4887 - Starting new sequences with "Plus" icon on canvas
* #5136 - Starting new sequence by typing in sequence mode

- added enabling edit mode by entering symbol on empty canvas
- added blinking cell on empty canvas
- reworked selection for sequence items
- added buttons for new sequences between lines
This was referenced Aug 1, 2024
Open
Open
@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue Aug 5, 2024
Open
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

@Zhirnoff Zhirnoff mentioned this issue Aug 14, 2024
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Test Cases Written Test cases has been written for that issue
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4887 - Starting new sequences with "Plus" icon on canvas epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Andrey-Antonov @olganaz @ljubica-milovic