Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI renders monomer labels in different way than on user machine #4586

Open
AlexeyGirin opened this issue May 7, 2024 · 0 comments
Open

CI renders monomer labels in different way than on user machine #4586

AlexeyGirin opened this issue May 7, 2024 · 0 comments

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Open test results: playwright-report.zip

Actual behavior
Not that some screenshots are different:
image
This is because on CI system renders labels in on pixel down:
image

Expected behavior
Labels should be rendered in the same way everywhere

Versions [e.g. v2.4.2].

  • Indigo Toolkit Version 1.20.0-rc.2.0-g111a89f35-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-07; 12:32:44
  • Chrome Version Version 124.0.6367.119 (Official Build) (64-bit)
  • Windows 10
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.1 milestone May 7, 2024
AlexeyGirin added a commit that referenced this issue May 8, 2024
…4571)

* first draft

* 3809 - Macro: Connection rules for RNA monomers

* Removing pretier

* More prettier removed

* Changes scale in order to got stable screenshots

* Some tests are feailed due to #4586 issue

* Screens update

* maxDiffPixelRatio update

* Code clean up

* Failed tests removed
@AlexeyGirin AlexeyGirin removed the bug label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants