Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Text-editing mode, the canvas is not moved to make the newly added sequence visible #4526

Closed
Tracked by #6600
ViktoriaTkacheva opened this issue Apr 23, 2024 · 1 comment · Fixed by #6224
Closed
Tracked by #6600

In the Text-editing mode, the canvas is not moved to make the newly added sequence visible #4526

ViktoriaTkacheva opened this issue Apr 23, 2024 · 1 comment · Fixed by #6224
Assignees
@kostrubin
Labels
Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 3.0.0-rc....

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Steps to Reproduce

  1. Switch to the Macro mode - the Text-editing mode

  2. Add sequences to the canvas until they vertically fill the viewport (without using the scroll bar)

    image

  3. Press the “Enter” key, and enter one more sequence by typing it manually or by pasting it via Ctrl+V

Actual behavior
The canvas is not moved to make the newly added sequence visible

Expected behavior
The canvas should be moved to make the newly added sequence visible

Screenshots

2024-04-23_15h09_54.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (124.0.6367.60) x64

Ketcher version 2.21.0-rc.1, Build at 2024-04-15; 20:06:01

Issue found while testing #3916
@ViktoriaTkacheva ViktoriaTkacheva added this to the Refined Backlog milestone Apr 23, 2024
@Guch1g0v Guch1g0v self-assigned this Dec 19, 2024
@kostrubin kostrubin assigned kostrubin and unassigned Guch1g0v Dec 27, 2024
kostrubin added a commit that referenced this issue Dec 27, 2024
@kostrubin
#4526 - In the Text-editing mode, the canvas is not moved to make the…
1d36dd1 
… newly added sequence visible
@kostrubin kostrubin linked a pull request Dec 27, 2024 that will close this issue
#4526 - In the Text-editing mode, the canvas is not moved to make the newly added sequence visible #6224
Merged
9 tasks
svvald added a commit that referenced this issue Dec 31, 2024
@svvald
#4526 – Update UI tests
4f6c378
svvald pushed a commit that referenced this issue Dec 31, 2024
@kostrubin @svvald
#4526 - In the Text-editing mode, the canvas is not moved to make the…
e90ccc1 
… newly added sequence visible
svvald added a commit that referenced this issue Dec 31, 2024
@svvald
#4526 – Update UI tests
87a2225
svvald added a commit that referenced this issue Dec 31, 2024
@kostrubin @svvald
#4526 - In the Text-editing mode, the canvas is not moved to make the…
256be60 
… newly added sequence visible (#6224)

* #4526 - In the Text-editing mode, the canvas is not moved to make the newly added sequence visible

* updated condition for scrolling

* #4526 – Update UI tests

---------

Co-authored-by: Nikita Chistousov <[email protected]>
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 2, 2025

Tested. Bug fixed.

2025-01-02_12h40_10.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.0.0-rc.1]
Indigo version
[Version 1.28.0-rc.1]

@AlexeyGirin AlexeyGirin mentioned this issue Mar 4, 2025
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostrubin kostrubin

Labels
Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
5 participants
@kostrubin @AlexeyGirin @Zhirnoff @Guch1g0v @ViktoriaTkacheva