Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Switching to Sequence mode causes page freeze #4405

Closed
AlexeyGirin opened this issue Apr 3, 2024 · 1 comment · Fixed by #4616 or #4628
Closed

Preview: Switching to Sequence mode causes page freeze #4405

AlexeyGirin opened this issue Apr 3, 2024 · 1 comment · Fixed by #4616 or #4628
Assignees
@rrodionov91
Labels
Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.21.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Apr 3, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro
  2. Load from file: Freeze in sequence mode.zip
  3. Switch to Sequence mode

Actual behavior
Page freezes

Expected behavior
No freeze

  A
  |
p A
|
A p

Versions:
Windows 10
Chrome Version 112.0.5615.138 (Official Build) (64-bit)
Ketcher Version 2.20.0-rc.2 Build at 2024-04-02; 05:31:05
Indigo Toolkit Version 1.20.0-dev.1.19-gd0224f91-wasm32-wasm-clang-12.0.0

Issue found in the context of testing - #3734
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.21.0-rc.1 milestone Apr 3, 2024
@AlexeyGirin AlexeyGirin changed the title Switching to Sequence mode causes page freeze Macro: Switching to Sequence mode causes page freeze Apr 10, 2024
@AlexeyGirin AlexeyGirin added the Sequence mode Bucket: Sequence mode related issues label Apr 25, 2024
mate-meszaros-epam added a commit that referenced this issue May 8, 2024
@mate-meszaros-epam
#4405 – Macro: Switching to Sequence mode causes page freeze | Extrac…
4c6d4a0 
…ting a code thet causes freetzing
rrodionov91 added a commit that referenced this issue May 13, 2024
@rrodionov91
#4405 - Macro: Switching to Sequence mode causes page freeze
c327511 
- refactored snake layout to work with ChainsCollection
@rrodionov91 rrodionov91 linked a pull request May 13, 2024 that will close this issue
#4405 - Macro: Switching to Sequence mode causes page freeze #4616
Merged
9 tasks
rrodionov91 added a commit that referenced this issue May 15, 2024
@rrodionov91
#4405 - Macro: Switching to Sequence mode causes page freeze (#4616)
bf462b4 
- refactored snake layout to work with ChainsCollection
- fixed chains sorting to use Y coordinate more than X
@AlexeyGirin AlexeyGirin changed the title Macro: Switching to Sequence mode causes page freeze Preview: Switching to Sequence mode causes page freeze May 15, 2024
rrodionov91 added a commit that referenced this issue May 15, 2024
@rrodionov91
#4405 - Macro: Switching to Sequence mode causes page freeze (#4616)
4978f15 
- refactored snake layout to work with ChainsCollection
- fixed chains sorting to use Y coordinate more than X
@rrodionov91 rrodionov91 linked a pull request May 15, 2024 that will close this issue
Backmerge: #4405 - Macro: Switching to Sequence mode causes page freeze #4628
Merged
9 tasks
rrodionov91 added a commit that referenced this issue May 15, 2024
@rrodionov91
#4405 - Macro: Switching to Sequence mode causes page freeze (#4616)
c05b22c 
- refactored snake layout to work with ChainsCollection
- fixed chains sorting to use Y coordinate more than X
rrodionov91 added a commit that referenced this issue May 15, 2024
@rrodionov91
Backmerge: #4405 - Macro: Switching to Sequence mode causes page free…
14e8fac 
…ze (#4628)

- refactored snake layout to work with ChainsCollection
- fixed chains sorting to use Y coordinate more than X
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.21.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @mate-meszaros-epam @ilya-asiyuk-epam